Skip to content

remove checking types of input data by using hard typing arguments of… #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 28, 2017
Merged

remove checking types of input data by using hard typing arguments of… #100

merged 5 commits into from
Sep 28, 2017

Conversation

kadzielawa
Copy link

… method

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@naydav
Copy link

naydav commented Sep 17, 2017 •
edited
Loading

Looks good
But looks some api interfaces are missed, for exmaple:

Several notices:
return:
\Magento\InventoryApi\Api\GetAssignedSourcesForStockInterface::execute (will return array)
\Magento\InventoryApi\Api\SourceItemRepositoryInterface::getList
\Magento\InventoryApi\Api\SourceRepositoryInterface
\Magento\InventoryApi\Api\StockRepositoryInterface

@naydav naydav mentioned this pull request Sep 27, 2017
Closed
@naydav naydav merged commit 15cbd7a into develop Sep 28, 2017
RomaKis pushed a commit that referenced this pull request Mar 13, 2018
@magento-engcom-team
ENGCOM-732: MAGETWO-70390 selection can change qty #100
23baebf 
 - Merge Pull Request magento-engcom/import-export-improvements#100 from adam-paterson/import-export-improvements:MAGETWO-70390-selection-can-change-qty
 - Merged commits:
   1. 77fefd8
   2. fe9054e
RomaKis pushed a commit that referenced this pull request Mar 13, 2018
ENGCOM-732: MAGETWO-70390 selection can change qty #100
d8333f9
@smoskaluk smoskaluk mentioned this pull request Mar 23, 2018
Closed
@kadzielawa kadzielawa deleted the feature/msi-hard-typing-arguments branch May 21, 2018 07:34
sidolov pushed a commit that referenced this pull request Oct 18, 2019
@kabothu
Merge pull request #100 from magento-arcticfoxes/MC-20337
9360d2a 
Merging MC-20337 to MC-19451 branch
magento-cicd2 pushed a commit that referenced this pull request Apr 5, 2021
@zakdma
Merge pull request #100 from magento-tsg/2.4-develop-sidecar-pr18
ca3af73 
[Sidecar] Integration tests delivery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maghamed maghamed maghamed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Award: special achievement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kadzielawa @naydav @maghamed