Skip to content

Complex products present on category page when has status 'Out of stock' #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Complex products present on category page when has status 'Out of stock' #2814

wants to merge 5 commits into from

Conversation

@nmalevanec
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Complex products present on category page when has status 'Out of stock' #1821: Complex products present on category page when has status 'Out of stock'

Manual testing scenarios (*)

  1. see Complex products present on category page when has status 'Out of stock' #1821

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@smoskaluk
Copy link

smoskaluk commented Feb 10, 2020 •
edited
Loading

@nmalevanec Please recheck configurable product - when I changed status for parent into 'Out of stock' - on product page on frontend still displays 'In stock' status

conf

@nmalevanec
Copy link
Contributor Author

@nmalevanec Please recheck configurable product - when I changed status for parent into 'Out of stock' - on product page on frontend still displays 'In stock' status

conf

@smoskaluk, please re-check. Should be fixed now.

sidolov
sidolov requested changes Feb 11, 2020
View reviewed changes
InventoryConfigurableProductIndexer/Indexer/SelectBuilder.php
'parent_product_entity.' . $linkField . ' = parent_link.parent_id',
[]
)->joinInner(
['parent_stock' => $this->resourceConnection->getTableName('cataloginventory_stock_item')],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid cataloginventory_stock_item table usage? CatalogInventory module will be deprecated and removed in the next releases, we should use Inventory logic only to handle such cases.

@sidolov
Copy link
Contributor

sidolov commented Feb 14, 2020

Hi @nmalevanec let's discuss how to fix the issue properly without dependency to the deprecated modules. I'm closing the PR for now. Thanks!

@sidolov sidolov closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov requested changes

Assignees

@sidolov sidolov

Labels

Progress: changes requested QA Passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmalevanec @smoskaluk @sidolov