MSI magento-engcom/magento#65: #76
Conversation
- Add test and functionality to support `OutOfStock` SourceItem
- Add the test case - Impelment Adjust StockItem aggregation functionality to support Disabled Sources
| @@ -0,0 +1,69 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Need to merge develop brunch and adapt tests according to possibility to pre-define id
There was a problem hiding this comment.
Need to simplify fixture files
https://github.com/magento-engcom/magento2/pull/76/files#diff-c8b20cde2aec460219d830973d4b6321
like in
https://github.com/magento-engcom/magento2/blob/develop/app/code/Magento/InventoryApi/Test/_files/source_items.php
Now it is possible after merge
https://github.com/magento-engcom/magento2/pull/79
We try to describe more details in our article
https://github.com/magento-engcom/magento2/wiki/The-first-step-towards-pre-generated-IDs.-And-how-this-will-improve-your-Integration-tests
| if (count($sourceIds)) { | ||
| $select->where(Source::SOURCE_ID . ' = ?', $sourceIds); | ||
| } | ||
| $sourceIds = $connection->fetchCol($select); |
There was a problem hiding this comment.
Need to check this condition
If we do not have enabled sources then we need to return empty data without extra queries
| @@ -0,0 +1,69 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Need to simplify fixture files
https://github.com/magento-engcom/magento2/pull/76/files#diff-c8b20cde2aec460219d830973d4b6321
like in
https://github.com/magento-engcom/magento2/blob/develop/app/code/Magento/InventoryApi/Test/_files/source_items.php
Now it is possible after merge
https://github.com/magento-engcom/magento2/pull/79
We try to describe more details in our article
https://github.com/magento-engcom/magento2/wiki/The-first-step-towards-pre-generated-IDs.-And-how-this-will-improve-your-Integration-tests
- Add new test case for all sources are disabled - Simplify test case to new structure
-- global refactoring
|
|
-- global refactoring
-- internal build fixes
No description provided.