Skip to content

Conversation

@zetlen
Copy link
Contributor

@zetlen zetlen commented Jun 4, 2020

Description

  • Change all hardcoded colors in Venia CSS stylesheets to use CSS Variables instead.
  • Add a postcss transform type to the transformModules target, to enable third-party manipulation of CSS.

Together these changes enable large-scale CSS transformations like the dark theme example shown here, which integrates with the code in this PR.

Acceptance

Verification Stakeholders

Community!

Verification Steps

Follow the walkthrough to test the color theme.

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 4, 2020

Fails
🚫

node` failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/pwa-buildpack/lib/Utilities/__tests__/loadEnvironment.spec.js
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against cb598ca

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 4, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2460.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2460.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.34, LH Best Practices Expected 1 Actual 0.92
https://pr-2460.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.48, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@zetlen zetlen force-pushed the zetlen/targetable-css branch from ecdc008 to cb598ca Compare June 11, 2020 20:56
@davemacaulay
Copy link
Contributor

As there has been no movement on this PR in a significant amount of days we are going to close it, if you intend to continue work on this PR please comment and we can re-open it.

@sirugh sirugh deleted the zetlen/targetable-css branch April 26, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants