snk/hng64.cpp: Further cleanups from https://github.com/mamedev/mame/pull/14275 #14276
+10
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix error in required_region_ptr - Move logmacro include in ipp file into hng64_v.cpp - Fix possibly transparent pen issue - Make some variables constant - Minor optimization - Reduce duplicates - Use BIT for single bit values
|
This has conflicts. Also, please make sure you test your changes. The previous pull request failed validation and caused the games to fail to start. |
|
I still really disagree with this BIT macro stuff, it does nothing but obfuscate. If I'm looking at the memory in the debugger I see hex values, having to convert them to and from bit positions because the code uses BIT is not fun or helpful at all. I know this is policy, but it's really fucking stupid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.