cpu/mb86235: Use separate memory spaces for data A and external #14285
+87
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes enemy car collision detection in stcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each Model 2C game the copro TGPx4 initialization procedure writes a list of function addresses to data A and afterwards writes 0 to external address 0x2C, which in the current code is mapped to data A so it ends up corrupting the address of copro function 0x2C. This commit separates data A and external memory so this no longer occurs.
Fixes enemy car collision detection in stcc, probably other bugs in Model 2C games we hadn't discovered