Avoid using a hard coded earth radius in compute destination point #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your PR! For some reason the CI fails now: Could you please have a look and check if it's your change that's causing these failed tests? Doesn't really make sense to me but it worked before. |
Owner
|
Ok, it does make sense because we have earth radius |
Author
|
Indeed, it most certainly is because the tests on computeDestinationPoint are based on that hard coded value of the earth radius. To me it would make sense to use the same value of earth radius across functions, if you agree I can update the tests.
|
Author
|
@manuelbieh just pushed a commit to fix the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #290