MLE-24523 Getting reverse proxy tests running again #1841
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
rjrudin
force-pushed
the
feature/24523-huh
branch
3 times, most recently
from
fc6ea2b to
8040575
Compare
Lots of little improvements to Jenkinsfile too.
rjrudin
force-pushed
the
feature/24523-huh
branch
from
8040575 to
eaeacb0
Compare
rjrudin
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR is focused on fixing and re-enabling reverse proxy server tests that were previously commented out. The main goal is to resolve configuration issues that were preventing these tests from running correctly.
Key changes include:
- Updated port configurations for test environments
- Fixed Gradle task references for reverse proxy server execution
- Re-enabled previously disabled reverse proxy test stages in Jenkins pipeline
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/README.md | Added documentation for running tests with reverse proxy server |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/BulkIOCallersFnTest.java | Changed test port from 8093 to 8015 |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestDatabaseClientConnection.java | Updated error message assertion to be more flexible |
| docker-compose.yaml | Consolidated port mappings and added comment explaining port range |
| Jenkinsfile | Re-enabled reverse proxy tests, updated Docker images, and fixed Gradle task references |
| .copyrightconfig | Added docker-compose.yaml to excluded files list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| ./gradlew -PtestUseReverseProxyServer=true test-app:runReverseProxyServer marklogic-client-api-functionaltests:runFragileTests || true | ||
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api-functionaltests:runFragileTests || true |
There was a problem hiding this comment.
The Gradle task reference has been changed from test-app:runReverseProxyServer to runReverseProxyServer across multiple lines. Ensure this task is defined at the root project level or verify that the task resolution works correctly without the project prefix.
Copilot uses AI. Check for mistakes.
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| ./gradlew -PtestUseReverseProxyServer=true test-app:runReverseProxyServer marklogic-client-api-functionaltests:runFastFunctionalTests || true | ||
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api-functionaltests:runFastFunctionalTests || true |
There was a problem hiding this comment.
The Gradle task reference has been changed from test-app:runReverseProxyServer to runReverseProxyServer across multiple lines. Ensure this task is defined at the root project level or verify that the task resolution works correctly without the project prefix.
Copilot uses AI. Check for mistakes.
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| ./gradlew -PtestUseReverseProxyServer=true test-app:runReverseProxyServer marklogic-client-api-functionaltests:runSlowFunctionalTests || true | ||
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api-functionaltests:runSlowFunctionalTests || true |
There was a problem hiding this comment.
The Gradle task reference has been changed from test-app:runReverseProxyServer to runReverseProxyServer across multiple lines. Ensure this task is defined at the root project level or verify that the task resolution works correctly without the project prefix.
Copilot uses AI. Check for mistakes.
| To run one or more tests with the reverse proxy server being started, the tests being run, and then the server being | ||
| stopped, do the following (you can see examples of this in the project `Jenkinsfile` as well): | ||
|
|
||
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api:test --tests ReadDocumentPageTest |
There was a problem hiding this comment.
[nitpick] The indentation uses tabs instead of spaces, which is inconsistent with the rest of the documentation that uses spaces. Consider using consistent spacing for better readability.
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api:test --tests ReadDocumentPageTest | |
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api:test --tests ReadDocumentPageTest |
Copilot uses AI. Check for mistakes.
1 participant
No description provided.