Skip to content

Conversation

@barkhachoithani
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@pengzhouml pengzhouml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that we add the image pullSecret to the StatefulSet. The request is actually asking to add the secret to the Operator deployment.

Copy link
Collaborator

@rwinieski rwinieski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImagePullSecret should be available for :

The Operator Helm chart (for all Docker image used)
The MarkLogic Statefulset (s)
HAProxy deployment

@pengzhouml
Copy link
Collaborator

I approved because the -image-pull-secrets flag works. However, there are many changes are not belong to this PR for helm Charts, can you please remove these change. we can create another one for helm chart update

@barkhachoithani
Copy link
Collaborator Author

I approved because the -image-pull-secrets flag works. However, there are many changes are not belong to this PR for helm Charts, can you please remove these change. we can create another one for helm chart update

Those changes are added as @rwinieski requested changes in the comment above.

@barkhachoithani barkhachoithani merged commit bd12204 into marklogic:develop Feb 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants