Skip to content

Conversation

@adzironman
Copy link
Collaborator

Summary

Changelog

Test Plan

@adzironman adzironman changed the title Rn e2e cucumber new approach RNTester - e2e cucumber new approach Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Fails
🚫

❗ Base Branch - The base branch for this PR is something other than main or a -stable branch. Are you sure you want to target something other than the main branch?

🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against be4415d

@adzironman adzironman marked this pull request as ready for review January 10, 2023 15:35
Copy link
Collaborator

@elizabethberger elizabethberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are small things - we can discuss any.

@adzironman adzironman merged commit 6e655c3 into feature/rn-e2e-cucumber Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants