Skip to content

Conversation

melissawm
Copy link
Member

PR Summary

The CircleCI artifact redirector action (which creates the docs preview links in PRs) is failing. This is due to an upstream bug. Following the advice on that thread, this PR adds the api-token definition in the configuration file for the action.

PR Checklist

Documentation and Tests

  • [N/A] Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Co-authored-by: Thomas A Caswell <[email protected]>
@jklymak
Copy link
Member

jklymak commented Apr 12, 2023

I don't know if that helps or not - we are failing way earlier when we try and install codecov?

@QuLogic
Copy link
Member

QuLogic commented Apr 12, 2023

Can you drop codecov/coverage here? Re: https://matrix.to/#/!BXmyZMTnRjWJldDRLV:gitter.im/$_KoAHkkUoHKgNSvjo0ByDF0XZWwSXJaErOodoYzi8AQ?via=gitter.im&via=matrix.org&via=aria-net.org

@melissawm
Copy link
Member Author

Ok - I think this is ready (I don't think the CI failures are related).

This will only work once merged to main - you can see similar work done here: scipy/scipy#18292

@QuLogic QuLogic added this to the v3.7.2 milestone Apr 13, 2023
@rcomer
Copy link
Member

rcomer commented Apr 17, 2023

@meeseeksdev backport to v3.7.1-doc

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 17, 2023
@rcomer rcomer modified the milestones: v3.7.2, v3.7-doc Apr 17, 2023
oscargus added a commit that referenced this pull request Apr 17, 2023
…672-on-v3.7.1-doc

Backport PR #25672 on branch v3.7.1-doc (MAINT: Add api-token for CircleCI redirector action)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants