Create RCKeyType #30316
Create RCKeyType #30316
Conversation
|
Hi @ZPyrolink do you need some help getting this PR ready for review? |
# Conflicts: # lib/matplotlib/typing.py
|
Hi, sorry, I was taking a break and forgot to push my last commit and set the PR as ready for review. I only had one problem with mypy corrected with a use of RcKeyType and # type: ignore[index] (I don't know if there is another solution for this one). |
| super().__init__(default_font_prop, load_glyph_flags) | ||
| for texfont in "cal rm tt it bf sf bfit".split(): | ||
| prop = mpl.rcParams['mathtext.' + texfont] | ||
| prop = mpl.rcParams['mathtext.' + texfont] # type: ignore[index] |
There was a problem hiding this comment.
There is no getter for a group so I think ignoring the error is the only solution.
There was a problem hiding this comment.
I assume mypy is complaining here. Would it help to make the list explicit?
for texfont in ["cal", "rm", "tt", "it", "bf", "sf", "bfit"]:There was a problem hiding this comment.
Unfortunately mypy consider textfont as a str and the sum also as str so we have the same error
There was a problem hiding this comment.
Ok in that case, ignoring is likely the simplest solution.
| super().__init__(default_font_prop, load_glyph_flags) | ||
| for texfont in "cal rm tt it bf sf bfit".split(): | ||
| prop = mpl.rcParams['mathtext.' + texfont] | ||
| prop = mpl.rcParams['mathtext.' + texfont] # type: ignore[index] |
There was a problem hiding this comment.
Ok in that case, ignoring is likely the simplest solution.
|
This is a bit outdated, but I'm going to merge and open a followup PR. |
4 participants
PR summary
This PR create types for the RC (Runtime Configuration)
RcKeyTypeRcGroupTypeThese types are used on:
RcParams.__setitem__RcParams.__getitem__matplotlib.rcPR checklist