Warnings from code generation

[eringh]

Sometimes, like when I run tests or build the docs, I get the following warning.

WARNING: Method definition (::Type{GraphMatFun.LangC_MKL})(Any, Any) in module GraphMatFun at C:\Users\emilr\Documents\GitHub\GraphMatFun.jl\src\code_gen\gen_c_code.jl:11 overwritten at C:\Users\emilr\Documents\GitHub\GraphMatFun.jl\src\code_gen\gen_c_code.jl:33.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition (::Type{GraphMatFun.LangC_OpenBLAS})(Any, Any) in module GraphMatFun at C:\Users\emilr\Documents\GitHub\GraphMatFun.jl\src\code_gen\gen_c_code.jl:22 overwritten at C:\Users\emilr\Documents\GitHub\GraphMatFun.jl\src\code_gen\gen_c_code.jl:33.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition (::Type{GraphMatFun.LangJulia})(Any, Any, Any) in module GraphMatFun at C:\Users\emilr\Documents\GitHub\GraphMatFun.jl\src\code_gen\gen_julia_code.jl:5 overwritten at C:\Users\emilr\Documents\GitHub\GraphMatFun.jl\src\code_gen\gen_julia_code.jl:16.
  ** incremental compilation may be fatally broken for this module **

Ia am not sure what it is. Line 11 seems strange, but around line 33 we have

GraphMatFun.jl/src/code_gen/gen_c_code.jl

Lines 31 to 38 in ebd1478

	for L in [:LangC_MKL, :LangC_OpenBLAS]
	eval(quote
	function $L(gen_main=false,overwrite_input=true)
	return $L(gen_main,overwrite_input)
	end
	end
	)
	end

Anyone have any ideas?
I have not experienced any actual problems though.

[jarlebring]

It should go away if we expand to loop over LangC_MKL, LangC_OpenBLAS. The expansion into two constructors will not be longer anyway.

[mfasi]

I think that the warnings were due to the implicit 2-parameter (in C) and 3-parameter (in Julia) constructors were being redefined. I defined the empty constructors and the 1-parameter constructor explicitly. Another option could be to define the structs using the Base.@kwdef macro, so that the default constructors have kwargs rather than positional parameters.

[eringh]

The warning seems to have disappeared for me. 👍