-
Notifications
You must be signed in to change notification settings - Fork 1
More GitHub actions #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[](https://matrixfunctions.github.io/GraphMatFun.jl/dev) | ||
[](https://travis-ci.com/matrixfunctions/GraphMatFun.jl) | ||
[](https://github.com/matrixfunctions/GraphMatFun.jl/actions/workflows/ContinuousIntegration.yml) | ||
[](https://codecov.io/gh/matrixfunctions/GraphMatFun.jl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the role of the "token" now? The discourse example https://raw.githubusercontent.com/invenia/PkgTemplates.jl/master/README.md suggests it would be [](https://codecov.io/gh/matrixfunctions/GraphMatFun.jl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our repository the query string is necessary, and in fact the badge doesn't work without it: compare
https://codecov.io/gh/matrixfunctions/GraphMatFun.jl/branch/master/graph/badge.svg
with
https://codecov.io/gh/matrixfunctions/GraphMatFun.jl/branch/main/graph/badge.svg?token=ZTKNBNMDEZ.
The markdown snippet is the one recommended on the Codecov settings for our repository:
https://app.codecov.io/gh/matrixfunctions/GraphMatFun.jl/settings/badge
Then, it looks good to me. 👍
|
Are you sure the Documentation.yml is running? It seems the documentation is not regenerated, and there is some error message https://github.com/matrixfunctions/GraphMatFun.jl/deployments/activity_log?environment=github-pages |
Thank you for spotting these two issues. The error in the logs was not related to this pull request. The last build of the documentation had failed two weeks ago, and re-deploying now was unsuccessful because the generated files were missing. I've changed the rules for |
👍 |
Closes #68.