Skip to content

Conversation

mfasi
Copy link
Collaborator

@mfasi mfasi commented Jul 13, 2022

Closes #68.

@mfasi mfasi requested a review from jarlebring July 13, 2022 12:39
[![Dev](https://img.shields.io/badge/docs-dev-blue.svg)](https://matrixfunctions.github.io/GraphMatFun.jl/dev)
[![Build Status](https://travis-ci.com/matrixfunctions/GraphMatFun.jl.svg?token=1D6L5XDzryqshBZ5ijUH&branch=main)](https://travis-ci.com/matrixfunctions/GraphMatFun.jl)
[![Tests](https://img.shields.io/github/workflow/status/matrixfunctions/GraphMatFun.jl/ContinuousIntegration?label=tests)](https://github.com/matrixfunctions/GraphMatFun.jl/actions/workflows/ContinuousIntegration.yml)
[![codecov](https://codecov.io/gh/matrixfunctions/GraphMatFun.jl/branch/main/graph/badge.svg?token=ZTKNBNMDEZ)](https://codecov.io/gh/matrixfunctions/GraphMatFun.jl)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the role of the "token" now? The discourse example https://raw.githubusercontent.com/invenia/PkgTemplates.jl/master/README.md suggests it would be [![Codecov](https://codecov.io/gh/matrixfunctions/GraphMatFun.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/matrixfunctions/GraphMatFun.jl)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our repository the query string is necessary, and in fact the badge doesn't work without it: compare

https://codecov.io/gh/matrixfunctions/GraphMatFun.jl/branch/master/graph/badge.svg

with

https://codecov.io/gh/matrixfunctions/GraphMatFun.jl/branch/main/graph/badge.svg?token=ZTKNBNMDEZ.

The markdown snippet is the one recommended on the Codecov settings for our repository:

https://app.codecov.io/gh/matrixfunctions/GraphMatFun.jl/settings/badge

@jarlebring
Copy link
Collaborator

jarlebring commented Jul 13, 2022 via email

@mfasi mfasi merged commit 9ed3c66 into main Jul 13, 2022
@jarlebring
Copy link
Collaborator

Are you sure the Documentation.yml is running? It seems the documentation is not regenerated, and there is some error message https://github.com/matrixfunctions/GraphMatFun.jl/deployments/activity_log?environment=github-pages

@mfasi
Copy link
Collaborator Author

mfasi commented Jul 14, 2022

Thank you for spotting these two issues.

The error in the logs was not related to this pull request. The last build of the documentation had failed two weeks ago, and re-deploying now was unsuccessful because the generated files were missing.

I've changed the rules for Documentation.yml so that now the documentation is built and deployed every time a commit is pushed to any branch. It seems to be working as expected now.

@jarlebring
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition of CI

2 participants