Skip to content

Conversation

mfasi
Copy link
Collaborator

@mfasi mfasi commented Jan 17, 2024

After the lincomb update, there is a lot of unused code in this file. This PR is to clean things up a bit. I've only removed the obvious things for now, but it seems to me that everything having to do with the axpby_header can go, as this was only used in code that I've removed.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40c792e) 94.29% compared to head (b7846cb) 96.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   94.29%   96.91%   +2.61%     
==========================================
  Files          30       30              
  Lines        2558     2460      -98     
==========================================
- Hits         2412     2384      -28     
+ Misses        146       76      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jarlebring
Copy link
Collaborator

While we're doing cleanup.... Maybe drop legacy support?

if VERSION > v"1.7.0-DEV.1240"

@mfasi
Copy link
Collaborator Author

mfasi commented Jan 17, 2024

All done, I think.

@jarlebring
Copy link
Collaborator

Nice!

@jarlebring
Copy link
Collaborator

Ready for merge? I would like to make a new release.

@mfasi
Copy link
Collaborator Author

mfasi commented Jan 23, 2024

Ready for merge? I would like to make a new release.

I had forgotten about this one – I'll merge and I'm happy for a new release. Should this be 1.1.0?

@jarlebring
Copy link
Collaborator

👍 Yes. This should be 1.1.0 according to julia version number guidelines.

@mfasi mfasi merged commit 40603fb into main Jan 23, 2024
@mfasi
Copy link
Collaborator Author

mfasi commented Jan 23, 2024

👍 Yes. This should be 1.1.0 according to julia version number guidelines.

All done – the version will be updated in the next merge round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants