-
Notifications
You must be signed in to change notification settings - Fork 1
Remove unused code gen_code/gen_julia_code.jl
#79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 94.29% 96.91% +2.61%
==========================================
Files 30 30
Lines 2558 2460 -98
==========================================
- Hits 2412 2384 -28
+ Misses 146 76 -70 ☔ View full report in Codecov by Sentry. |
While we're doing cleanup.... Maybe drop legacy support? GraphMatFun.jl/src/code_gen/gen_julia_code.jl Line 344 in 873afcc
|
Tests in test/code_gen_test.jl are updated accordingly
All done, I think. |
Nice! |
Ready for merge? I would like to make a new release. |
I had forgotten about this one – I'll merge and I'm happy for a new release. Should this be 1.1.0? |
👍 Yes. This should be 1.1.0 according to julia version number guidelines. |
All done – the version will be updated in the next merge round. |
After the
lincomb
update, there is a lot of unused code in this file. This PR is to clean things up a bit. I've only removed the obvious things for now, but it seems to me that everything having to do with theaxpby_header
can go, as this was only used in code that I've removed.