Skip to content

[EVM] Move the EVMFinalizeStackFrames pass to the end of the codegen pipeline #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[EVM] Move the EVMFinalizeStackFrames pass to the end of the codegen pipeline #924

wants to merge 1 commit into from

Conversation

@PavelKopyl
Copy link
Contributor

@PavelKopyl PavelKopyl commented Oct 23, 2025 •
edited
Loading

This allows other passes to modify or adjust frame indexes before finalization.

Code Review Checklist

Purpose

Ticket Number

Requirements

  • Have the requirements been met?
  • Have stakeholder(s) approved the change?

Implementation

  • Does this code change accomplish what it is supposed to do?
  • Can this solution be simplified?
  • Does this change add unwanted compile-time or run-time dependencies?
  • Could an additional framework, API, library, or service improve the solution?
  • Could we reuse part of LLVM instead of implementing the patch or a part of it?
  • Is the code at the right abstraction level?
  • Is the code modular enough?
  • Can a better solution be found in terms of maintainability, readability, performance, or security?
  • Does similar functionality already exist in the codebase? If yes, why isn’t it reused?
  • Are there any best practices, design patterns or language-specific patterns that could substantially improve this code?

Logic Errors and Bugs

  • Can you think of any use case in which the
    code does not behave as intended?
  • Can you think of any inputs or external events
    that could break the code?

Error Handling and Logging

  • Is error handling done the correct way?
  • Should any logging or debugging information
    be added or removed?
  • Are error messages user-friendly?
  • Are there enough log events and are they
    written in a way that allows for easy
    debugging?

Maintainability

  • Is the code easy to read?
  • Is the code not repeated (DRY Principle)?
  • Is the code method/class not too long?

Dependencies

  • Were updates to documentation, configuration, or readme files made as required by this change?
  • Are there any potential impacts on other parts of the system or backward compatibility?

Security

  • Does the code introduce any security vulnerabilities?

Performance

  • Do you think this code change decreases
    system performance?
  • Do you see any potential to improve the
    performance of the code significantly?

Testing and Testability

  • Is the code testable?
  • Have automated tests been added, or have related ones been updated to cover the change?
    • For changes to mutable state
  • Do tests reasonably cover the code change (unit/integration/system tests)?
    • Line Coverage
    • Region Coverage
    • Branch Coverage
  • Are there some test cases, input or edge cases
    that should be tested in addition?

Readability

  • Is the code easy to understand?
  • Which parts were confusing to you and why?
  • Can the readability of the code be improved by
    smaller methods?
  • Can the readability of the code be improved by
    different function, method or variable names?
  • Is the code located in the right
    file/folder/package?
  • Do you think certain methods should be
    restructured to have a more intuitive control
    flow?
  • Is the data flow understandable?
  • Are there redundant or outdated comments?
  • Could some comments convey the message
    better?
  • Would more comments make the code more
    understandable?
  • Could some comments be removed by making the code itself more readable?
  • Is there any commented-out code?
  • Have you run a spelling and grammar checker?

Documentation

  • Is there sufficient documentation?
  • Is the ReadMe.md file up to date?

Best Practices

  • Follow Single Responsibility principle?
  • Are different errors handled correctly?
  • Are errors and warnings logged?
  • Magic values avoided?
  • No unnecessary comments?
  • Minimal nesting used?

Experts' Opinion

  • Do you think a specific expert, like a security
    expert or a usability expert, should look over
    the code before it can be accepted?
  • Will this code change impact different teams, and should they review the change as well?

@PavelKopyl
[EVM] Move the EVMFinalizeStackFrames pass to the end of the codegen …
50ed21a 
…pipeline

This allows other passes to modify or adjust frame indexes before finalization.
@PavelKopyl PavelKopyl marked this pull request as draft October 23, 2025 18:34
@PavelKopyl PavelKopyl changed the title [EVM] Move the EVMFinalizeStackFrames pass to the end of the codegen … [EVM] Move the EVMFinalizeStackFrames pass to the end of the codegen pipeline Oct 23, 2025
@github-actions
Copy link

📊 evm compiler-tester excel report

Benchmarks measured for:

  • target machine: evm
  • toolchain: ir-llvm
  • environment: REVM

➡️ Download Excel Report

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.00%. Comparing base (f26f9ce) to head (50ed21a).

Files with missing lines Patch % Lines
llvm/lib/Target/EVM/EVMCalculateModuleSize.cpp 0.00% 2 Missing and 1 partial ⚠️
llvm/lib/Target/EVM/EVMTargetMachine.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #924       +/-   ##
===========================================
- Coverage   30.94%   30.00%    -0.95%     
===========================================
  Files        2430     2430               
  Lines      806322   704092   -102230     
  Branches   176496   176497        +1     
===========================================
- Hits       249490   211239    -38251     
+ Misses     512928   448940    -63988     
- Partials    43904    43913        +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

📊 Excel Report Available

Benchmarks measured for:

  • solx candidate version: solx, LLVM-based Solidity compiler for the EVM v0.1.3, LLVM revision: v1.0.2, LLVM build: 50ed21ac239c34ae4090537e8d2fd61c4e8720f9
  • solx ToT version: solx, LLVM-based Solidity compiler for the EVM v0.1.3, LLVM revision: v1.0.2, LLVM build: f26f9cea62dc5a8e228c0c211309ae222704ded4
  • solx latest release version: solx, LLVM-based Solidity compiler for the EVM v0.1.2, LLVM revision: v1.0.2, LLVM build: aec023355f43d8ece02249360ba84e749fb5cb3f
  • solc version: 0.8.30

➡️ Download Excel Report

@github-actions
Copy link

Project Mode Compiled (solc / solx / Total) Passed (solc / solx / Total)
openzeppelin default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 382 / 382 / 382 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 328 / 328 / 330
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 382 / 382 / 382 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 328 / 328 / 330
lil-web3 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 68 / 68 / 68
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 66 / 68 / 68
maple-erc20 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 28 / 28 / 28 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 29 / 29 / 29
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 28 / 28 / 28 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 29 / 29 / 29
diamonds default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 17 / 17 / 17 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 / 1 / 1
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 17 / 17 / 17 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 / 1 / 1
rollcall default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 64 / 64 / 64 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 14 / 14 / 14
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 64 / 64 / 64 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 14 / 14 / 14
playpen default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 43 / 43 / 43 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 6 / 6 / 9
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 43 / 43 / 43 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 6 / 6 / 9
solmate default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 60 / 60 / 60 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 55 / 55 / 69
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 60 / 60 / 60 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 55 / 55 / 69
prb-math default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 106 / 106 / 106 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 323 / 323 / 323
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 106 / 106 / 106 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 323 / 323 / 323
solady default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 208 / 208 / 208 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1571 / 1571 / 1571
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 208 / 208 / 208 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1571 / 1571 / 1571
unix default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 21 / 21 / 21 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 2 / 2 / 3
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 21 / 21 / 21 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 2 / 0
foundry-upgrades default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 22 / 22 / 22 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 3 / 3 / 3
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 22 / 22 / 22 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 3 / 3 / 3
art-gobblers default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 56 / 56 / 56 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 127 / 127 / 127
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 56 / 56 / 56 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 121 / 121 / 127
lens-core default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 320 / 320 / 320 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 1876 / 0
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 320 / 320 / 320 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 1877 / 0
balance-snapshot default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 5 / 5 / 5
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 / 20 / 20 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 5 / 5 / 5
diamond-foundry default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 26 / 26 / 26 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 40 / 40 / 44
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 26 / 26 / 26 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 40 / 40 / 44
forge-std default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 50 / 50 / 50 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 194 / 194 / 194
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 50 / 50 / 50 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 194 / 194 / 194
tokenlon default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 121 / 121 / 121 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 53 / 53 / 67
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 121 / 121 / 121 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 53 / 53 / 67
uniswap-v4 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 160 / 160 / 160 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 598 / 598 / 598
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 160 / 160 / 160 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 598 / 598 / 598
beefy default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 164 / 164 / 164 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 2 / 2 / 34
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 164 / 164 / 164 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 2 / 2 / 34
gov-of-venice default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 25 / 25 / 25 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 25 / 25 / 26
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 25 / 25 / 25 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 24 / 25 / 26
cicada default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 23 / 23 / 23 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 546 / 0
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 23 / 23 / 23 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 546 / 0
lens-v3 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 240 / 240 / 240 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 656 / 656 / 657
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 240 / 240 / 240 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 0 / 656 / 0
morpho-blue default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 74 / 74 / 74 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 145 / 145 / 145
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 74 / 74 / 74 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 145 / 145 / 145
aave-v3 default 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 473 / 473 / 473 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 980 / 980 / 980
viaIR 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 473 / 473 / 473 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 979 / 980 / 980

@github-actions
Copy link

Project Mode Compile (solx/solc/Δs/Δ%) Run (solx/solc/Δs/Δ%) Size warnings (solx/solc)
openzeppelin default 13.90s / 18.10s / -4.20s / -23% 📉 2.51s / 2.83s / -0.32s / -11% 📉 2 / 3
viaIR 14.73s / 57.63s / -42.89s / -74% 📉 2.48s / 3.21s / -0.73s / -23% 📉 2 / 3
lil-web3 default 2.60s / 2.30s / +0.30s / +13% 📈 0.15s / 0.14s / +0.01s / +3% ➖ 0 / 0
viaIR 2.18s / 10.11s / -7.93s / -78% 📉 0.15s / 0.14s / +0.01s / +4% ➖ 1 / 1
maple-erc20 default 2.08s / 1.75s / +0.33s / +19% 📈 0.16s / 0.16s / +0.00s / +1% ➖ 0 / 0
viaIR 1.80s / 4.97s / -3.17s / -64% 📉 0.16s / 0.16s / +0.00s / +0% ➖ 0 / 0
diamonds default 1.99s / 1.00s / +0.98s / +98% 📈 0.49s / 0.47s / +0.01s / +2% ➖ 0 / 0
viaIR 1.63s / 2.54s / -0.92s / -36% 📉 0.50s / 0.47s / +0.03s / +6% 📈 0 / 0
rollcall default 2.68s / 2.80s / -0.13s / -4% ➖ 0.16s / 0.16s / +0.00s / +1% ➖ 0 / 2
viaIR 2.35s / 10.20s / -7.85s / -77% 📉 0.15s / 0.16s / -0.00s / -3% ➖ 1 / 2
playpen default 2.55s / 1.84s / +0.71s / +39% 📈 0.17s / 0.17s / +0.01s / +4% ➖ 0 / 6
viaIR 2.09s / 7.24s / -5.15s / -71% 📉 0.17s / 0.17s / +0.01s / +4% ➖ 0 / 6
solmate default 8.87s / 5.72s / +3.15s / +55% 📈 0.14s / 0.13s / +0.01s / +6% 📈 2 / 7
viaIR 5.12s / 32.19s / -27.07s / -84% 📉 0.14s / 0.13s / +0.01s / +7% 📈 4 / 9
prb-math default 6.21s / 6.62s / -0.42s / -6% 📉 0.16s / 0.16s / -0.00s / -2% ➖ 0 / 0
viaIR 7.59s / 30.38s / -22.79s / -75% 📉 0.16s / 0.16s / +0.00s / +3% ➖ 0 / 0
solady default 21.30s / 26.42s / -5.12s / -19% 📉 0.66s / 0.67s / -0.01s / -2% ➖ 19 / 21
viaIR 20.74s / 159.22s / -138.48s / -87% 📉 0.67s / 0.68s / -0.02s / -2% ➖ 25 / 23
unix default 2.93s / 1.76s / +1.17s / +66% 📈 0.22s / 0.22s / +0.00s / +2% ➖ 0 / 1
viaIR 2.08s / 4.64s / -2.56s / -55% 📉 0.22s / 0.29s / -0.07s / -24% 📉 0 / 0
foundry-upgrades default 1.43s / 0.98s / +0.45s / +45% 📈 0.19s / 0.17s / +0.02s / +13% 📈 0 / 0
viaIR 1.17s / 2.93s / -1.77s / -60% 📉 0.20s / 0.20s / +0.00s / +2% ➖ 0 / 0
art-gobblers default 9.25s / 5.26s / +3.99s / +76% 📈 0.67s / 0.76s / -0.10s / -13% 📉 1 / 19
viaIR 7.10s / 28.52s / -21.41s / -75% 📉 0.70s / 0.78s / -0.08s / -10% 📉 1 / 22
lens-core default 123.54s / 12.60s / +110.95s / +881% 📈 3.37s / 15.69s / -12.32s / -79% 📉 85 / 0
viaIR 81.35s / 597.22s / -515.88s / -86% 📉 3.36s / 710.53s / -707.17s / -100% 📉 83 / 0
balance-snapshot default 2.36s / 0.92s / +1.44s / +158% 📈 0.15s / 0.14s / +0.01s / +6% 📈 0 / 0
viaIR 1.85s / 2.90s / -1.05s / -36% 📉 0.15s / 0.15s / -0.00s / -3% ➖ 0 / 0
diamond-foundry default 3.11s / 2.28s / +0.83s / +36% 📈 0.14s / 0.13s / +0.01s / +11% 📈 0 / 1
viaIR 1.88s / 6.24s / -4.36s / -70% 📉 0.14s / 0.14s / +0.00s / +1% ➖ 0 / 0
forge-std default 10.13s / 7.93s / +2.19s / +28% 📈 2.13s / 1.65s / +0.48s / +29% 📈 7 / 7
viaIR 7.07s / 37.79s / -30.72s / -81% 📉 1.93s / 2.39s / -0.46s / -19% 📉 8 / 8
tokenlon default 17.98s / 19.30s / -1.31s / -7% 📉 0.25s / 0.27s / -0.01s / -5% 📉 10 / 26
viaIR 12.00s / 98.08s / -86.08s / -88% 📉 0.26s / 0.26s / -0.00s / -1% ➖ 12 / 28
uniswap-v4 default 21.78s / 18.21s / +3.57s / +20% 📈 2.62s / 2.65s / -0.03s / -1% ➖ 4 / 33
viaIR 15.67s / 101.29s / -85.62s / -85% 📉 2.65s / 2.62s / +0.03s / +1% ➖ 7 / 35
beefy default 15.67s / 19.99s / -4.31s / -22% 📉 0.21s / 0.20s / +0.01s / +4% ➖ 14 / 27
viaIR 13.16s / 106.68s / -93.52s / -88% 📉 0.21s / 0.20s / +0.01s / +4% ➖ 16 / 26
gov-of-venice default 5.22s / 3.64s / +1.58s / +43% 📈 0.48s / 0.59s / -0.11s / -19% 📉 2 / 10
viaIR 3.52s / 24.44s / -20.92s / -86% 📉 0.52s / 0.58s / -0.06s / -10% 📉 2 / 10
lens-v3 default 77.42s / 50.09s / +27.33s / +55% 📈 0.41s / 0.46s / -0.06s / -12% 📉 32 / 60
viaIR 46.90s / 10.83s / +36.07s / +333% 📈 0.39s / 10.80s / -10.40s / -96% 📉 33 / 0
morpho-blue default 9.70s / 11.84s / -2.15s / -18% 📉 0.21s / 0.21s / -0.00s / -1% ➖ 6 / 34
viaIR 7.81s / 67.28s / -59.47s / -88% 📉 0.21s / 0.21s / +0.00s / +0% ➖ 9 / 33
aave-v3 default 297.88s / 117.08s / +180.80s / +154% 📈 0.81s / 0.69s / +0.12s / +18% 📈 82 / 164
viaIR 128.39s / 963.57s / -835.18s / -87% 📉 0.66s / 0.66s / +0.01s / +1% ➖ 84 / 164

@PavelKopyl PavelKopyl closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PavelKopyl