Skip to content

Conversation

@veeso
Copy link
Contributor

@veeso veeso commented Nov 30, 2020

Hello, I hope you'll accept this pull request, since this library is really important for Rust FTP support. Really, there's nothing decent out there for FTP in Rust.

These changes solve deprecation warnings and updates all the crates to the latest version. In addition I replaced openssl with native_tls to make it easier to run on Windows and MacOs machine.

Changes

I tested the commit and everything is fine.

EDIT (2020-12-02)

I also merged what you already did on branch stable-updates, which sounded good to me.

EDIT (2020-12-03)

I reported the patches from async-rust-ftp (which is a library derived from this one).
Eventually I replaced openssl with native_tls, which makes it easy to run on MacOS and Windows.


For those who read this merge request and are looking for a way to apply these changes before the new published version, just add this to Cargo.toml

# ...
[dependencies]
# ...
ftp = { git = "https://github.com/ChristianVisintin/rust-ftp" , features = ["secure"] }
# ...

@veeso veeso changed the title Removed deprecated statements and updated dependencies General restyling - Removed deprecated statements and updated dependencies Dec 3, 2020
@mattnenterprise mattnenterprise merged commit 32259e8 into mattnenterprise:master Dec 16, 2020
@mattnenterprise
Copy link
Owner

@ChristianVisintin Thanks for making these updates. I plan on actively maintaining the project from here on out. Seeing as your an active user of this library any feedback on it would be nice.

@veeso veeso deleted the 2020-porting branch August 18, 2021 07:49
@veeso veeso restored the 2020-porting branch August 18, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants