ci: adopt build-push-ecr shared action for deployment #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
had a problem deploying
to
dev-orange
GitHub Actions
Failure
boringcactus
had a problem deploying
to
dev-orange
GitHub Actions
Failure
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
This reverts commit 33ea0ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #10, loading the Docker container as cached in GitHub Actions isn't possible in the current version of
mbta/actions/build-push-ecr. However, as of mbta/actions#41, it will be. Or at least it should be, which is why I'm testing this here.Validating that named releases work properly without a prod to deploy to required a bit of creativity.