feat: allow CORS from dotcom local dev #384
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
added
the
deploy to dev-orange
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
thecristen
reviewed
Sep 25, 2025
| plug Plug.Head | ||
| plug Plug.Session, @session_options | ||
|
|
||
| plug CORSPlug, origin: ["http://localhost:4001"] |
There was a problem hiding this comment.
@boringcactus maybe you should put it in the :api pipeline in the router? For whatever reason it isn't working for me 😬
There was a problem hiding this comment.
Putting it here is recommended by the docs, since if we put it in the router we have to also declare OPTIONS handlers in addition to our GET handlers.
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
temporarily deployed
to
dev-orange
GitHub Actions
Inactive
boringcactus
removed
the
deploy to dev-orange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: none
Requested by the dotcom team for their exploration of the JS export.