Skip to content

Conversation

@cyberman54
Copy link

suppress compiler warning if using custom pin mapping

suppress compiler warning if using custom pin mapping
@frazar
Copy link

frazar commented Jan 29, 2019

Would it make sense to remove the message altogether?
Compilation would fail anyway if lmic_pins is not defined, so the user would know.

@terrillmoore
Copy link
Member

I added this message because if things are misconfigured, beginning users may get a runtime failure due to a nullptr dereference without any way to troubleshoot. #pragma message() is not portable. I agree that if the warning is being emitted when you know what you're doing, it's also annoying, especially if you're not using the routine. It would be better to change this to an LMIC_DEBUG() that warns the user before returning NULL. However, I will merge this now and file a new bug report, as there is no backward-compatibility issue.

@terrillmoore terrillmoore merged commit 4650e89 into mcci-catena:master Feb 10, 2019
@cyberman54 cyberman54 deleted the patch-1 branch February 10, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants