-
Notifications
You must be signed in to change notification settings - Fork 793
loader: Add boot hook for slot selection #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
loader: Add boot hook for slot selection #2402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not how common code should work, bootutil is a common file for any RTOS, any zephyr specific code goes in boot/zephyr, and there should be no checking of e.g. Kconfigs in common code
Is there a place for a code that is zephyr-specific, yet should be shared between the app and bootloader? Honestly, I had an impression that the shared code/library problem is not fully resolved in the MCUboot ATM, so we are seeking for good ideas here 🙂 Side note: that's one of the reasons why this is a draft PR. |
Depends what it is, if it's zephyr centric then it can go into zephyr itself (e.g. boot mode is in zephyr and used in apps and mcuboot), I'm not sure what this code really does or what part is meant to be shared |
91713dd
to
c58b35c
Compare
Sine the boot request API is used by the bootutil logic, I decided to move it into the MCUBoot include directory. If you agree on the current split, I'll add a note about the new configuration option inside the MCUboot docs. |
c58b35c
to
e3d5b8e
Compare
Scope reduced to the bootloader hook for the active slot selection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate Zephyr and bootutil code into different commits.
e3d5b8e
to
85dc002
Compare
85dc002
to
aa5fd8b
Compare
Add a bootloader hook to alter the logic of the active slot selection in Direct XIP modes. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add a Kconfig option to enable a bootloader hook to alter the logic of the active slot selection in Direct XIP modes. Signed-off-by: Tomasz Chyrowicz <[email protected]>
aa5fd8b
to
fba755f
Compare
Add a bootloader hook to alter the logic of the active slot selection in Direct XIP modes.