This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Do not account ack length before ssl handshake finish #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good patch, fix device reboot. Please, raise version in library.json: "version": "1.1.3" to be updated by PlatformIO |
|
@Adam5Wu sorry mate... have been busy and totally neglected the libs :) merged now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible way to fix #85.
Another way is to somehow track handshake sent bytes in
_tx_unacked_len, I think it may be too much effort to worth the benefit... :P