[WC-2838]: Implement RefreshIndicator component on Datagrid 2 #1765
+150
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
force-pushed
the
feat/WC-2838-dg2-refresh-indicator
branch
3 times, most recently
from
28b8013 to
7801661
Compare
samuelreichert
force-pushed
the
feat/WC-2838-dg2-refresh-indicator
branch
3 times, most recently
from
3adb85c to
fa456e1
Compare
samuelreichert
force-pushed
the
feat/WC-2838-dg2-refresh-indicator
branch
from
13ea577 to
6b07406
Compare
… from GridBody component
…e in Widget component
samuelreichert
force-pushed
the
feat/WC-2838-dg2-refresh-indicator
branch
from
6b07406 to
1b42ea2
Compare
iobuhov
reviewed
Jul 30, 2025
| @@ -56,7 +56,7 @@ describe("DatasourceController loading states", () => { | |||
| }); | |||
|
|
|||
| it("all loading states return false", () => { | |||
| expect(controller.isLoading).toBe(false); | |||
| expect(controller.isFirstLoad).toBe(true); | |||
There was a problem hiding this comment.
It's better to change this test to reflect new behavior.
iobuhov
requested changes
Jul 30, 2025
| @@ -39,13 +39,13 @@ describe("DatasourceController loading states", () => { | |||
| provider.setProps({ datasource: list.loading() }); | |||
| expect(provider.gate.props.datasource.status).toBe("loading"); | |||
| expect(controller.isRefreshing).toBe(true); | |||
| expect(controller.isLoading).toBe(false); | |||
| expect(controller.isFirstLoad).toBe(true); | |||
There was a problem hiding this comment.
I think something wrong here, isFirstLoad should be false after setProps on line 35. But it remains true, why?
| @@ -21,8 +21,8 @@ describe("DatasourceController loading states", () => { | |||
| provider.setProps({ datasource }); | |||
| }); | |||
|
|
|||
| it("isLoading returns true by default", () => { | |||
| expect(controller.isLoading).toBe(true); | |||
| it("isFirstLoad returns true by default", () => { | |||
There was a problem hiding this comment.
I think we should create more "real world" test. Let's use BaseControllerHost on line 13. And between lines 15 and 16 add host.setup() call. This will make sure we setup listeners.
| @@ -105,6 +114,11 @@ export class DatasourceController implements ReactiveController, QueryController | |||
| } | |||
|
|
|||
| setup(): () => void { | |||
| when( | |||
There was a problem hiding this comment.
I think to keep consistency, we should use disposeBatch here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Implement a new property to show a refresh indicator. With the refresh indicator any datasource change triggers the progress bar on top of the Datagrid2.