Implement support for the FUNCTION-DICT category
#438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was the same issue as mercedes-benz#437... Signed-off-by: Andreas Lauser <[email protected]> Approved-by: Christian Hackenbeck <[email protected]>
this category is used to describe functional addressing. Signed-off-by: Andreas Lauser <[email protected]> Approved-by: Christian Hackenbeck <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Approved-by: Christian Hackenbeck <[email protected]>
…DX category Signed-off-by: Andreas Lauser <[email protected]> Approved-by: Christian Hackenbeck <[email protected]>
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
| {%- elif phys_segment.end_address is defined %} | ||
| {#- #}xsi:type="ADDRDEF-PHYS-SEGMENT" | ||
| {#- #} xsi:type="ADDRDEF-PHYS-SEGMENT" |
There was a problem hiding this comment.
Move to their own PR please
There was a problem hiding this comment.
done: #439 (already merged)
kayoub5
reviewed
Jul 23, 2025
kayoub5
reviewed
Jul 23, 2025
as usual, the thanks go to [at]kayoub5... Signed-off-by: Andreas Lauser <[email protected]>
since we now support all of them, we can safely do so. as usual, thanks to [at]kayoub5 for noticing. Signed-off-by: Andreas Lauser <[email protected]>
…UNCTION-DICTIONARY-SPEC` this seems to be a quirk of the standard. thanks to [at]kayoub5 for wondering about it. Signed-off-by: Andreas Lauser <[email protected]>
andlaus
force-pushed
the
function_dictionary
branch
from
bd2264c to
f8e675a
Compare
…1` and `W293` this was a copy-and-pasto from the ECU config unit test. thanks to [at]kayoub5 for noticing. Signed-off-by: Andreas Lauser <[email protected]>
|
@kayoub5: do you see any remaining showstoppers here? |
kayoub5
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FUNCTION-DICTis used to describe functional addressing, some kind of multicast mechanism. The details of this are outlined in section 7.4.9 of the ASAM version of the standard.This is the last missing ODX category, i.e., after this PR has been merged, odxtools ought to cover the full ODX standard when it comes to reading and writing of ODX data (modulo bugs).
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information