Add meaningful error messages #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another possibility would be depending on https://github.com/alexei/sprintf.js which looks at lot like the inline sprintf-implementation. |
|
It is the alexei implementation, just inlined. Feel free to just re-inline the latest. |
|
Wouldn't it be better to depend on it in the package.json? This means updates in the future will be easier to incorporate. I am willing to do this work. |
|
Happy to take a PR. It works like it currently does because I released Jed in 2012 and sprintf wasn't on Github until 2013. It was just a file on his website. |
Closed
akshaybhasme-adobe
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was bitten by
[sprintf] huh?, this should make debugging for other people much easier.