-
Notifications
You must be signed in to change notification settings - Fork 43
Refactor mupdf-sys build script #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44be5b8 to
aaf5ae9
Compare
Collaborator
Author
|
I'm not sure whether this is sth that should be able to happen: Edit: It seems to be this bug. Using node 20.19.1 instead of 18.20.8 allows the code to run fine. |
messense
approved these changes
May 22, 2025
Owner
messense
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_string_lossyfor paths. Replaced with.to_strorOsStrdirectly instead.zerocopya optional feature formupdf-sys.target_envfrom env vars as wellDon't copysrcintobuild. Not possible yet, are symlinks a better idea than copying?Maybe in the future, just improved copy for now
wasm32-unknown-emscripten#123