Skip to content

Conversation

@ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented May 6, 2025

  • Split make and msbuild in two seperate files.
  • Remove uses of to_string_lossy for paths. Replaced with .to_str or OsStr directly instead.
  • Split bindgen docs and zerocopy callbacks.
  • Make zerocopy a optional feature for mupdf-sys.
  • Improved and more error messages
  • Check target_env from env vars as well
  • Don't copy src into build. Not possible yet, are symlinks a better idea than copying?
    Maybe in the future, just improved copy for now
  • Integrate and complete wasm compilation support from WIP: Try to get it to compile on wasm32-unknown-emscripten #123
  • Add WASM CI
  • Link C++

@ginnyTheCat
Copy link
Collaborator Author

ginnyTheCat commented May 15, 2025

I'm not sure whether this is sth that should be able to happen:

#
# Fatal error in , line 0
# Check failed: IdField::is_valid(id).
#
#
#
#FailureMessage Object: 0x7fe6cdffb9a0
----- Native stack trace -----
 1: 0xd43461  [node]
 2: 0x218eab1 V8_Fatal(char const*, ...) [node]
 3: 0x227500d v8::internal::compiler::Node::New(v8::internal::Zone*, unsigned int, v8::internal::compiler::Operator const*, int, v8::internal::compiler::Node* const*, bool) [node]
 4: 0x220d5b0 v8::internal::compiler::Graph::NewNode(v8::internal::compiler::Operator const*, int, v8::internal::compiler::Node* const*, bool) [node]
 5: 0x21b3a02 v8::internal::compiler::WasmGraphBuilder::LoopExitValue(v8::internal::compiler::Node*, v8::internal::MachineRepresentation) [node]
 6: 0x1733b3f  [node]
 7: 0x173a948  [node]
 8: 0x173ad39  [node]
 9: 0x17488e7 v8::internal::wasm::BuildTFGraph(v8::internal::AccountingAllocator*, v8::internal::wasm::WasmFeatures const&, v8::internal::wasm::WasmModule const*, v8::internal::compiler::WasmGraphBuilder*, v8::internal::wasm::WasmFeatures*, v8::internal::wasm::FunctionBody const&, std::vector<v8::internal::compiler::WasmLoopInfo, std::allocator<v8::internal::compiler::WasmLoopInfo> >*, v8::internal::wasm::DanglingExceptions*, v8::internal::compiler::NodeOriginTable*, int, v8::internal::wasm::AssumptionsJournal*, v8::internal::wasm::InlinedStatus) [node]
10: 0x21df8ce v8::internal::compiler::ExecuteTurbofanWasmCompilation(v8::internal::wasm::CompilationEnv*, v8::internal::compiler::WasmCompilationData&, v8::internal::Counters*, v8::internal::wasm::WasmFeatures*) [node]
11: 0x1726137 v8::internal::wasm::WasmCompilationUnit::ExecuteFunctionCompilation(v8::internal::wasm::CompilationEnv*, v8::internal::wasm::WireBytesStorage const*, v8::internal::Counters*, v8::internal::wasm::AssemblerBufferCache*, v8::internal::wasm::WasmFeatures*) [node]
12: 0x17273ac v8::internal::wasm::WasmCompilationUnit::ExecuteCompilation(v8::internal::wasm::CompilationEnv*, v8::internal::wasm::WireBytesStorage const*, v8::internal::Counters*, v8::internal::wasm::AssemblerBufferCache*, v8::internal::wasm::WasmFeatures*) [node]
13: 0x175b45e  [node]
14: 0x175c3f8  [node]
15: 0x1d75538 v8::platform::DefaultJobWorker::Run() [node]
16: 0xd43601  [node]
17: 0x7fe6d569caa4  [/lib/x86_64-linux-gnu/libc.so.6]
18: 0x7fe6d5729c3c  [/lib/x86_64-linux-gnu/libc.so.6]

Edit: It seems to be this bug. Using node 20.19.1 instead of 18.20.8 allows the code to run fine.

@ginnyTheCat ginnyTheCat marked this pull request as ready for review May 16, 2025 14:14
@ginnyTheCat ginnyTheCat requested a review from messense May 21, 2025 15:29
Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@messense messense merged commit 9ef9144 into messense:main May 22, 2025
14 checks passed
@ginnyTheCat ginnyTheCat deleted the build-refactor branch May 22, 2025 02:50
@Wybxc Wybxc mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants