Skip to content

Conversation

@newinnovations
Copy link
Contributor

This PR fixes the problem (#138) of building mupdf with visual studio 2022 which is part of the windows-2022 and windows-2025 github runners.

@ginnyTheCat
Copy link
Collaborator

How is it possible that visual studio 2022 does not define NAN? Shouldn't that exist since C99, or is mupdf missing a include that we could upstream?

Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@messense messense merged commit ed1d471 into messense:main May 9, 2025
13 checks passed
@ginnyTheCat
Copy link
Collaborator

This seams to have been fixed in Windows 11, Build 10.0.26100.3916 but it's prolly gonna take a while for everybody to get the update.

@newinnovations newinnovations deleted the main branch June 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants