Skip to content

X_pending for FixedFeatureAcquisition #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

X_pending for FixedFeatureAcquisition #1233

wants to merge 1 commit into from

Conversation

danielrjiang
Copy link
Contributor

Summary: Handle X_pending properly in FixedFeatureAcquisition

Reviewed By: Balandat

Differential Revision: D36466941

@facebook-github-bot
X_pending for FixedFeatureAcquisition
b8e8fec 
Summary: Handle X_pending properly in FixedFeatureAcquisition

Reviewed By: Balandat

Differential Revision: D36466941

fbshipit-source-id: 5d92df9769af14357aa6528c376dac32d301e052
@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels May 27, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36466941

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1233 (b8e8fec) into main (fbc3487) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##              main    #1233      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          122      122              
  Lines        10553    10562       +9     
===========================================
+ Hits         10553    10561       +8     
- Misses           0        1       +1
Impacted Files Coverage Δ
botorch/acquisition/fixed_feature.py 98.18% <90.00%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc3487...b8e8fec. Read the comment docs.

@Balandat Balandat mentioned this pull request May 28, 2022
Closed
facebook-github-bot pushed a commit that referenced this pull request May 28, 2022
@Balandat @facebook-github-bot
Bump coverage to 100% (#1234)
21426cf 
Summary:
#1233 missed a line, this adds test coverage for that

Pull Request resolved: #1234

Reviewed By: saitcakmak

Differential Revision: D36741767

Pulled By: Balandat

fbshipit-source-id: ffcd1c5c67125353aff233428cbed71d43d8039d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielrjiang @facebook-github-bot