[monarch] Fix type error in test_python_actors.py #1393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes broken github CI due to `ProcessAllocator` being marked final. Differential Revision: [D83671339](https://our.internmc.facebook.com/intern/diff/D83671339/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83671339/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 1, 2025
This fixes broken github CI due to `ProcessAllocator` being marked final. Differential Revision: [D83671339](https://our.internmc.facebook.com/intern/diff/D83671339/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83671339/)! ghstack-source-id: 313373542 Pull Request resolved: #1393
meta-cla
bot
added
the
CLA Signed
benjipelletier
pushed a commit
to benjipelletier/monarch-1
that referenced
this pull request
Oct 1, 2025
Summary: This fixes broken github CI due to `ProcessAllocator` being marked final. ghstack-source-id: 313373542 exported-using-ghexport Reviewed By: benjipelletier Differential Revision: D83671339
This fixes broken github CI due to `ProcessAllocator` being marked final. Differential Revision: [D83671339](https://our.internmc.facebook.com/intern/diff/D83671339/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83671339/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 1, 2025
Pull Request resolved: #1393 This fixes broken github CI due to `ProcessAllocator` being marked final. ghstack-source-id: 313443762 @exported-using-ghexport Differential Revision: [D83671339](https://our.internmc.facebook.com/intern/diff/D83671339/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83671339/)!
This fixes broken github CI due to `ProcessAllocator` being marked final. Differential Revision: [D83671339](https://our.internmc.facebook.com/intern/diff/D83671339/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83671339/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 1, 2025
Pull Request resolved: #1393 This fixes broken github CI due to `ProcessAllocator` being marked final. ghstack-source-id: 313483343 @exported-using-ghexport Differential Revision: [D83671339](https://our.internmc.facebook.com/intern/diff/D83671339/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83671339/)!
|
This pull request has been merged in 82ec519. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This fixes broken github CI due to
ProcessAllocatorbeing marked final.Differential Revision: D83671339
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!