Skip to content

Conversation

mglaman
Copy link
Owner

@mglaman mglaman commented May 24, 2022

No description provided.

@mxr576
Copy link
Contributor

mxr576 commented May 24, 2022

phpstan/phpstan version constraint should be also updated in composer.json,should not be?

Also, if similar changes are expected in upstream, maybe it is a good idea being specific about minor releases that this plugin should work otherwise Composer is going install incomplete versions, my suggestion is ~1.7.0 instead of ^1.7.

@mglaman
Copy link
Owner Author

mglaman commented May 24, 2022

That's probably a good idea. I'll need to add a new workflow on cron to test a more relaxed constraint to catch minor version breaks

@mglaman
Copy link
Owner Author

mglaman commented May 24, 2022

Actually, the break was due to code in phpstan-drupal from 0.11.x days. I kept the constraint at ^1.7.0 so folks can always have the latest and greatest. I have, however, added a new job to run PHPStan dev snapshot.

The problem is that PHPStan's branches are based on the version. So 1.7.x-dev will eventually be 1.8.x-dev. I asked if there's an easier way to track: phpstan/phpstan#7311

@mglaman mglaman merged commit ff4f58b into main May 24, 2022
@mglaman mglaman deleted the fix-1.7.0-compat branch May 24, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants