add support for class string service ids #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2022 20:13
mglaman
reviewed
Jun 16, 2022
Comment on lines
+81
to
+88
| if ($arg1 instanceof String_) { | ||
| // @todo determine what these types are. | ||
| return $arg1->value; | ||
| } | ||
|
|
||
| if ($arg1 instanceof ClassConstFetch && $arg1->class instanceof FullyQualified) { | ||
| return (string) $arg1->class; | ||
| } |
There was a problem hiding this comment.
I wonder if there's anyway to leverage PHPStan type system, which may abstract away some of this logic. But it may not be as accessible in these extensions
There was a problem hiding this comment.
Do I understand correctly, that you would like to ask phpstan if the argument is of type 'string' or 'class-string' instead of this?
Do you have any idea where to start looking to come up with a solution that does that (because I am not really experienced in phpstan source)?
There was a problem hiding this comment.
There was a problem hiding this comment.
We can ignore that other PR, it's experimental. Let's work on this first
mglaman
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this docs page using the fully qualified class name when interacting with services is a supported approach.
This PR adds the correct return type hint when this approach is used.