Add SymfonyCmfRouteObjectInterfaceConstantsRule

[mglaman]

Fixes #440

[larowlan]

This seems to be catching all uses of \Traversable and reporting them as deprecated, to be replaced with LazyRouteCollection

Return type of method Drupal\my_module\MyClass::getIterator() has  
         typehint with deprecated Traversable and is removed in Drupal 10. Use           
         \Drupal\Core\Routing\LazyRouteCollection instead.                               
         💡 Change record: https://www.drupal.org/node/3151009       

[larowlan]

It also seems to be recommending using core's LazyRouteCollection over the symfony RouteCollection (not the symfony-cmf one, the symfony/routing one)

Return type of method                                                                 
         Drupal\my_module\EntityHandlers\MyRoutingProvider::getRoutes() has         
         typehint with deprecated Symfony\Component\Routing\RouteCollection and is removed in  
         Drupal 10. Use \Drupal\Core\Routing\LazyRouteCollection instead.                      
         💡 Change record: https://www.drupal.org/node/3151009 

[mglaman]

Oh crud. I need to improve the test coverage. The CR recommended the core route collection class

[mglaman]

@larowlan pushing hotfix patch release which switches to equals vs isSuperOf. This fixes the RouteCollection issue as well (\Symfony\Cmf\Component\Routing\LazyRouteCollection extends it, so superOf was yes.) Same with RouteProvider.

[larowlan]

Thanks for the fast turnaround, cc @acbramley