ConditionalSettings for CI/CD or "Pull Request Build"

[peterelmqvist]

We have a ALGoOrgSettings to centralize configuration. I would like to have different behavior for CI/CD or "Pull Request Build" as oppose to other actions, something like below.

I can't get ConditionalSettings to work in this configuration. Is this not supported and if so, what is the supported way of doing this?

{
    "bcptTestFolders": [
    ],
    "ConditionalSettings": [
        {
            "settings": {
                "customCodeCops": [
                    "https://github.com/StefanMaron/BusinessCentral.LinterCop/releases/latest/download/BusinessCentral.LinterCop.dll"
                ],
                "failOn": "warning"
            },
            "workflows": [
                "CI/CD"
            ]
        },
        {
            "settings": {
                "customCodeCops": [
                    "https://github.com/StefanMaron/BusinessCentral.LinterCop/releases/latest/download/BusinessCentral.LinterCop.dll"
                ],
                "failOn": "warning"
            },
            "workflows": [
                "Pull Request Build"
            ]
        },
        {
            "settings": {
                "failOn": "warning",
                "gitHubRunner": "windows-latest"
            },
            "workflows": [
                "Test Next Minor"
            ]
        },
        {
            "settings": {
                "failOn": "error",
                "gitHubRunner": "windows-latest"
            },
            "workflows": [
                "Test Next Major"
            ]
        }
    ],
    "enableAppSourceCop": false,
    "enableCodeCop": true,
    "enablePerTenantExtensionCop": true,
    "enableUICop": true,
    "trustMicrosoftNuGetFeeds": false,
    "versioningStrategy": 0,
    "vsixFile": "latest"
}

[mazhelez]

The setup looks correct. Do you maybe have repo settings or project settings that might override these?

Can you upload the logs from a job that has a ReadSetting step? For example, a build job from a CICD workflow. If you do so, please make sure to remove any sensitive data from the logs.

[aholstrup1]

I believe the conditional setting for the CI/CD workflow should actually be the following (CICD rather than CI/CD):

"settings": {
                "customCodeCops": [
                    "https://github.com/StefanMaron/BusinessCentral.LinterCop/releases/latest/download/BusinessCentral.LinterCop.dll"
                ],
                "failOn": "warning"
            },
            "workflows": [
                "CICD"
            ]

The other conditional settings look correct to me though.

Could you try updating that and checking whether that helps?

[peterelmqvist]

Yes, it looks like that was the issue. The same thing goes for a workflow-specific file, like CICD.settings.json. Might be a little bit more obvious when it comes to filename.