-
Notifications
You must be signed in to change notification settings - Fork 22
SimdJson upgrade #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SimdJson upgrade #21
Conversation
… test for the new adapter
@microsoft-github-policy-service agree |
I will do a code review in a week. Dong |
Did a quick pass on the code. LGTM. @mnorfolk03 Can you run some basic performance regression tests for at least one dataset? For example, run an experiment on a large enough Github dataset and see how it compares with the old version. When it is done, please plot the figure and put it here for reference. @badrishc Could you please glance over the code as well? Also, we are switching the CI/CD to Github Actions for better integration. |
I think the code looks fine. @badrishc Can you check if it looks good to you? If so, I will merge it back to master. |
Updated simdjson to the latest version.
Now fields are identified as json ("x.y") rather than the previous slash method ("x/y"), thus the tests have been updated to accommodate this.
Additionally, added a GitHub workflow to run the tests.