-
Notifications
You must be signed in to change notification settings - Fork 91
Make SDK resolution error messages more helpful. #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
YuliiaKovalova
merged 2 commits into
microsoft:main
from
teo-tsirpanis:hostfxr-error-writer
Oct 2, 2025
Merged
Make SDK resolution error messages more helpful. #341
YuliiaKovalova
merged 2 commits into
microsoft:main
from
teo-tsirpanis:hostfxr-error-writer
Oct 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@teo-tsirpanis thank you for the contribution! |
YuliiaKovalova
approved these changes
Oct 2, 2025
This was referenced Oct 5, 2025
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
Contributor
Author
|
@YuliiaKovalova can you please add a |
This was referenced Oct 30, 2025
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331.
Fixes #337.
This PR makes use of the
hostfxr_set_error_writerAPI to capture SDK resolution error messages into a string. This lets us display it in the message of the exception we throw, and stop directing users to look at stderr. The exception message was also reworded to be shorter, and include the error code.