Skip to content

Conversation

@novacole
Copy link
Contributor

No description provided.

@MarcoRossignoli
Copy link

MarcoRossignoli commented Sep 1, 2023

cc: @nohwnd @Evangelink for review

@novacole novacole marked this pull request as ready for review February 9, 2024 00:33
@nohwnd
Copy link
Member

nohwnd commented Feb 9, 2024

I have been doing quite a lot of changes to vstest targets and tasks, I would love this to take dependency on stable version of https://www.nuget.org/packages/Microsoft.TestPlatform.Build which ships them.

@novacole
Copy link
Contributor Author

novacole commented Feb 9, 2024

@microsoft-github-policy-service agree company="Microsoft"

@novacole
Copy link
Contributor Author

novacole commented Feb 9, 2024

I have been doing quite a lot of changes to vstest targets and tasks, I would love this to take dependency on stable version of https://www.nuget.org/packages/Microsoft.TestPlatform.Build which ships them.

This no longer has a direct dependency on Microsoft.TestPlatform, it instead uses the vstest.console.exe shipped with VS for the MSBuild case, and for the dotnet case, it uses the one shipped with the dotnet sdk. @nohwnd

@dfederm dfederm merged commit b207ebd into microsoft:main Feb 9, 2024
@nohwnd
Copy link
Member

nohwnd commented Feb 13, 2024

Microsoft.TestPlatform**.Build** contains the msbuild task and target that we use to invoke vstest.console, depending I think that depending on it could avoid duplicating the task and target in this sdk, e.g. src/RunTests/RunVSTestTask.cs, we also have a new task and target that integrates better with msbuild and terminal logger that we are actively developing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants