Skip to content

Add a commandline option that takes in a metadata version for OpenAPI conversion #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2023
Merged

Add a commandline option that takes in a metadata version for OpenAPI conversion #1197

merged 5 commits into from
Mar 29, 2023

Conversation

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Mar 29, 2023

Adds the commandline option --metadata-version which takes in a metadata version parameter to be passed as a convert setting during CSDL to OpenApi conversion
Fixes #1196

baywet
baywet requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change, can you also update the weekly generation progress please?

@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi.Hidi/Program.cs
8befb81 
Remove unnecessary section in description

Co-authored-by: Vincent Biret <[email protected]>
@MaggieKimani1
Copy link
Contributor Author

MaggieKimani1 commented Mar 29, 2023

Thanks for making that change, can you also update the weekly generation progress please?

Sure

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

76.5% 76.5% Coverage
0.0% 0.0% Duplication

@MaggieKimani1 MaggieKimani1 enabled auto-merge March 29, 2023 14:49
@MaggieKimani1 MaggieKimani1 mentioned this pull request Mar 29, 2023
Merged
@MaggieKimani1 MaggieKimani1 merged commit c049346 into vnext Mar 29, 2023
@MaggieKimani1 MaggieKimani1 deleted the mk/add-version-command-option branch March 29, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Hidi to take in a version parameter as a command line option

3 participants

@MaggieKimani1 @baywet