Removes JsonSchema reference resolution when parsing a doc.
#1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are no longer resolving JsonSchema refs when parsing a doc., some tests need to be updated
irvinesunday
requested review from
MaggieKimani1,
andrueastman,
baywet,
darrelmiller,
millicentachieng,
peombwa and
zengin
as code owners
MaggieKimani1
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
JsonSchemareference resolution step when parsing a doc.JsonSchemareference resolution from the reference host document setting into separate classes.NB: By removing
JsonSchemareference resolution, we now don't validate whether theJsonSchemareferences concrete instances are defined in thecomponents/schemassection of a document (locally or externally).