Skip to content

Add OpenApiContact for ReadFragment #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add OpenApiContact for ReadFragment #892

merged 1 commit into from
Jun 23, 2022

Conversation

@matt9ucci
Copy link
Contributor

Currently, OpenApiStringReader.ReadFragment<OpenApiContact>() throws the following exception:

System.Collections.Generic.KeyNotFoundException : The given key 'Microsoft.OpenApi.Models.OpenApiContact'
was not present in the dictionary.

This is because OpenApiV2/V3VersionService._loaders does not have the entry of [typeof(OpenApiContact)].

@baywet baywet merged commit 4c8ab29 into microsoft:vnext Jun 23, 2022
@matt9ucci matt9ucci deleted the contact-fragment branch June 23, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@baywet baywet baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matt9ucci @darrelmiller @baywet