IdentifierCasing option enabling upper / lower / pascal-casing of all identifiers in ScriptWriter #178
+329
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing of all identifiers in ScriptWriter SqlScriptGeneratorOptions now supports a new setting IdentifierCasing with the following options: - PreserveOriginal — outputs identifiers as-is; this is the default behavior corresponding to the current state (no breaking change) - Lowercase — lower-case all identifiers when producing the output - Uppercase — upper-case all identifiers when producing the output - PascalCase — first character upper, remaining lower Added unit tests for the various options, including compatibility with KeywordCasing property and ensuring the default state.
ondrejtucny
requested review from
chlafreniere,
dzsquared,
kburtram,
llali and
ssreerama
as code owners
ondrejtucny
changed the title
|
@microsoft-github-policy-service agree company="BoldBrick" |
|
But wouldn't that be dangerous to change the casing of identifiers if they depend on the collation used by the containing DB? |
This is up to the caller (user of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced IdentifierCasing option enabling upper / lower / pascal-casing of all identifiers in
ScriptWriter. Resolves #177.SqlScriptGeneratorOptionsnow supports a new settingIdentifierCasingwith the following options:PreserveOriginal— outputs identifiers as-is; this is the default behavior corresponding to the current state (no breaking change)Lowercase— lower-case all identifiers when producing the outputUppercase— upper-case all identifiers when producing the outputPascalCase— first character upper, remaining lowerAdded unit tests for the various options, including compatibility with
KeywordCasingproperty and ensuring the default state.Code Changes