Mark legacy aliases with @deprecated #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
orta
approved these changes
Aug 1, 2021
Contributor
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
I think this is a good idea
| /** @deprecated This is a legacy alias of `scrollX`. */ | ||
| readonly pageXOffset: number; | ||
| /** @deprecated This is a legacy alias of `scrollY`. */ | ||
| readonly pageYOffset: number; |
Contributor
Author
|
LGTM 👍 |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kinda new, @orta @sandersn do you think this is good to have?