Run the deploy every night #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
approved these changes
Aug 17, 2021
Contributor
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
The push: thing now looks redundant, but the schedule thing looks good. LGTM
Contributor
|
Sorry @saschanaz, you don't have access to merge: /.github/workflows/deploy.yml. |
Contributor
Author
|
Agree, dropped it so that there's one 'canonical' way to deploy (and document) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mean that merged PRs via code-owners-self-merge trigger a deploy (eventually)