Fix LICENSE of published packages #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
DanielRosenwasser,
RyanCavanaugh and
sandersn
DanielRosenwasser
approved these changes
Aug 18, 2022
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
For all intents and purposes, I don't think it matters to most consumers. This was likely an oversight, but for consistency we should align with whatever lib.d.ts already ships as within TypeScript. Otherwise this will cause more issues down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license on this repo is Apache 2.0, and we also prepend an Apache 2.0 copyright header onto these files when distributed with TypeScript. But, when the packages like
@types/webwere introduced, they were instead shipped with the MIT license, which isn't the right one for this code.