mediation: "conditional" should be available now

[8ma10s]

PublicKeyCredential.isConditionalMediationAvailable() method is already available, mediation field's value "conditional" should also be available now.

TypeScript-DOM-lib-generator/baselines/dom.generated.d.ts

Line 11245 in 0337998

isConditionalMediationAvailable(): Promise<boolean>;

There was a previous issue that proposed the same thing, but it was closed because 'isConditionalMediationAvailable' was not available.
#1391

However, it's now available in both MDN document and this repo's baselines/ file.

[github-actions]

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

[8ma10s]

will update baseline

[saschanaz]

Only Safari supports it, and that's not enough: https://github.com/microsoft/TypeScript-DOM-lib-generator#why-is-my-fancy-api-still-not-available-here

A feature needs to be supported by two or more major browser engines to be included here, to make sure there is a good consensus among vendors: Gecko (Firefox), Blink (Chrome/Edge), and WebKit (Safari).

[saschanaz]

Credential.isConditionalMediationAvailable is WebKit-only (which somehow returns true instead of false) but PublicKeyCredential.isConditionalMediationAvailable is also in Blink.

LGTM thus.

[github-actions]

There was an issue merging, maybe try again saschanaz. Details

[saschanaz]

Oh actually, CLA?

[8ma10s]

@microsoft-github-policy-service agree

[8ma10s]

@saschanaz sorry I haven't checked back on this issue for a while. Just agreed. Please have a look at it again 🙏

[saschanaz]

LGTM 👍

[github-actions]

There was an issue merging, maybe try again saschanaz. Details

[saschanaz]

Has some breaking change happened in GitHub side?

LGTM

[github-actions]

There was an issue merging, maybe try again saschanaz. Details

[saschanaz]

Creating comments and merging
Merging (or commenting) failed:
Error: HttpError: Resource not accessible by integration
Error: Failed to merge

Huh?

[8ma10s]

weird. Maybe GitHub token has insufficient permissions...?

[saschanaz]

LGTM

It has been working, not sure what's changed.

[github-actions]

There was an issue merging, maybe try again saschanaz. Details

[saschanaz]

#1496 (comment) worked, so maybe it's this PR that is somehow broken? Can you try closing and reopening it?