-
Notifications
You must be signed in to change notification settings - Fork 453
Add override for import.meta.resolve()
#1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add override for import.meta.resolve()
#1740
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Maybe the extra field can have a lambda function type to make it simpler while keeping dictionary? |
Considered this, but this approach leads to interface merging conflicts in places like |
|
Oh no, but ImportMeta is not an interface at all. 😞 Can you at least add some comment why it should be an interface? |
|
The only alternative I can see is the deliciously hacky e341817... |
|
I guess interface is fine compared to that 😂 |
|
(But please add some comment in addedTypes) |
|
ref microsoft/TypeScript#23327 where the "interface" was added to be mergeable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks! LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Specification: HTML Standard 8.1.6.5.1
Reference: MDN
Reference: microsoft/TypeScript#58828
Converting
ImportMetato an interface seems fairly unavoidable, but I don't think it should break anything.