Partially fix crypto.getRandomValues type param
#2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Contributor
Author
|
I think fixing CI may require changes in
interface IntegerTypedArrayTypes {
Int8Array: Int8Array;
Int16Array: Int16Array;
Int32Array: Int32Array;
Uint8Array: Uint8Array;
Uint16Array: Uint16Array;
Uint32Array: Uint32Array;
Uint8ClampedArray: Uint8ClampedArray;
}
type IntegerTypedArray = IntegerTypedArrayTypes[keyof IntegerTypedArrayTypes];
interface IntegerTypedArrayTypes {
BigInt64Array: BigInt64Array;
BigUint64Array: BigUint64Array;
} |
Contributor
|
Maybe focus on removing null for now? |
Contributor
Author
@saschanaz can do, any chance of merging/reviewing the upstream PR as well though? Not sure if you're a maintainer for the main TS repo. |
Contributor
|
That's not under me, sorry. LGTM for this PR though. |
Contributor
|
There was an issue merging, maybe try again saschanaz. Details |
lionel-rowe
changed the title
crypto.getRandomValues type paramcrypto.getRandomValues type param
jakebailey
approved these changes
May 28, 2025
Contributor
|
lgtm |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1194