Do not add reexported names to the exportSpecifiers list of moduleinfo #39213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
approved these changes
Jun 24, 2020
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
Jun 24, 2020
* upstream/master: Do not add reexported names to the exportSpecifiers list of moduleinfo (microsoft#39213) Update user baselines (microsoft#39214) Leverage syntax cursor as part of reparse (microsoft#39216) Update failed test tracking to support Mocha 6+ (microsoft#39211) Update user baselines (microsoft#39196) LEGO: check in for master to temporary branch. # Conflicts: # src/compiler/parser.ts
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39195
A quick audit of the module info datapoints which were refactored into a helper function in #38809:
exportSpecifierswith this PR now again omits nonlocal specifiers (as all users expect only local specifiers, as they use the list to perform psuedo-name-resolution)exportedBindingscan contain the nonlocal exports (though didn't before Include reexported names in list of exported names #38809), since it's a map on original node ID, so including the reexports is fine (the remote entries simply won't be referenced by the users of the module info)exportedNamesexplicitly contains the reexports now to handle live bindings (which was the intended change in Include reexported names in list of exported names #38809).