Try file if matched pattern specifies the extension instead of all the time #42246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @sheetalkamat, I've started to run the parallelized community code test suite on this PR at cfe6b69. You can monitor the build here. |
Collaborator
|
Heya @sheetalkamat, I've started to run the extended test suite on this PR at cfe6b69. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
andrewbranch
approved these changes
Jan 8, 2021
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
…e time (microsoft#42246) * Test case for path mapping with extension * Try file if matched pattern specifies the extension instead of all the time Fixes microsoft#39743
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking for extension on resulting path, look if substitution of path mapping specifies the extension. Then only try the file as is, otherwise do normal module resolution for the resulting path
Fixes #39743