Tracing: dump more information about types #42962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
elibarzilay
approved these changes
Feb 25, 2021
Contributor
elibarzilay
left a comment
elibarzilay
left a comment
There was a problem hiding this comment.
Two minor comments.
Also: I'm guessing that this would make the time to dump it even longer -- maybe it would make sense to print something when it starts doing the type file dumps? (Both to avoid people complaining that the compiler became horribly slow, and to let them know that they can kill the process if they're just looking at the trace file.)
elibarzilay
approved these changes
Feb 27, 2021
Contributor
elibarzilay
left a comment
elibarzilay
left a comment
There was a problem hiding this comment.
Just a minor picky thing, if you care for it...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing some traces and discovered that there were type records with basically no properties.