Revert #43460 and #40884 #44175
Merged
Revert #43460 and #40884 #44175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft#43460)" This reverts commit 76a2ae3.
…teral and conditional statements (microsoft#40884)" This reverts commit 555ef73.
typescript-bot
added
Author: Team
For Uncommitted Bug
jessetrinity
force-pushed
the
revertBraceMatchingDiagnostics
branch
from
ce216c3 to
f537aef
Compare
sandersn
approved these changes
May 19, 2021
|
@typescript-bot cherry-pick this to release-4.3 |
1 similar comment
|
@typescript-bot cherry-pick this to release-4.3 |
jessetrinity
pushed a commit
to jessetrinity/TypeScript
that referenced
this pull request
May 20, 2021
* Revert "Only issue matching token errors on non-dupe locations (microsoft#43460)" This reverts commit 76a2ae3. * Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (microsoft#40884)" This reverts commit 555ef73. * re-add clobbered merge lines
jessetrinity
added a commit
to jessetrinity/TypeScript
that referenced
this pull request
May 27, 2021
This reverts commit 5770434.
sandersn
added a commit
that referenced
this pull request
Mar 16, 2022
…brackets (#44158) * Revert "Revert #43460 and #40884 (#44175)" This reverts commit 5770434. * fix missing opening brace match error * refactor parseExpectedMatchingBrackets * use getNodePos * accept baselines * delete mistakenly added files * Revert getNodePos addition Co-authored-by: Nathan Shively-Sanders <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #43460 and #40884 to cherry pick to 4.3 until we verify that we have a good fix in #44158.